Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-dialogs-declarative #513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceciliaavila
Copy link

Addresses # 4684
#minor

Description

This PR fixes the new ESLint errors and warnings that occur after upgrading the ESLint packages in the botbuilder-dialogs-declarative project.

Specific Changes

  • Removed the botbuilder-dialogs-declarative/eslint.config.cjs' file as it contained only the 'only-warn' plugin which was no longer needed.
  • Applied the auto fix flag for most issues (trailing commas and removal of unnecessary eslint exceptions).
  • Applied manual fixes for skipping the rule 'detect-non-literal-fs-filename' and replaced required with import.

Testing

The following images show the number of issues fixed in the library and the tests passing after the changes.
image

@ceciliaavila ceciliaavila changed the base branch from southworks/update/eslint-packages to main November 13, 2024 11:37
@ceciliaavila ceciliaavila force-pushed the southworks/fix/eslint-botbuilder-dialogs-declarative branch from 47a1bac to 4b811cc Compare November 13, 2024 11:37
@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11816471775

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.704%

Totals Coverage Status
Change from base Build 11691458662: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants