Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-testing #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link

Addresses # 4684
#minor

Description

This PR fixes all the new ESLint errors and warnings that appeared after the ESLint packages' upgrade in the botbuilder-testing project.

Specific Changes

  • Removed 'only-warn' plugin from 'botbuilder-testing'.
  • All updated TS files were due to prettier, and new jsdoc rules.

Testing

The following image shows that there are no more ESLint issues.
image

@sw-joelmut sw-joelmut changed the base branch from southworks/update/eslint-packages to main November 14, 2024 18:14
@sw-joelmut sw-joelmut force-pushed the southworks/fix/eslint-botbuilder-testing branch from 327a9dd to 4938629 Compare November 14, 2024 18:26
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11843259660

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 84.703%

Totals Coverage Status
Change from base Build 11691458662: -0.001%
Covered Lines: 20514
Relevant Lines: 23063

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants