Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in bobuilder-ai-orchestrator #502

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented Oct 24, 2024

Addresses # 4684
#minor

Description

This PR fixes the new errors and warnings incoming in the latest version of ESLint packages in bobuilder-ai-orchestrator.

Specific Changes

  • Removed eslint.config.cjs file.
  • Formatted with required spaces and comment lines required by ESLint.
  • Added some skips in rules that can be applied to the current logic.

Testing

The following image shows the lint command running without problems in botbuilder-ai-orchestrator.
image

@JhontSouth JhontSouth changed the base branch from main to southworks/update/eslint-packages October 24, 2024 16:47
Copy link

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check also the PR's description. I think there're typos in the detailed information.

@@ -1,11 +1,11 @@
const onlyWarn = require("eslint-plugin-only-warn");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing these files if they only contain the only-warnings setting.

@JhontSouth JhontSouth force-pushed the southworks/fix/eslint-issues-botbuilder-ai-orchestrator branch from 0a80c71 to ebab574 Compare November 13, 2024 18:54
@JhontSouth JhontSouth changed the base branch from southworks/update/eslint-packages to main November 13, 2024 18:54
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11841717274

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.704%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 1 68.83%
Totals Coverage Status
Change from base Build 11691458662: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants