fix: ESLint issues in bobuilder-core #489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested changes
Oct 24, 2024
sw-joelmut
requested changes
Oct 25, 2024
ceciliaavila
requested changes
Oct 28, 2024
ceciliaavila
approved these changes
Oct 28, 2024
sw-joelmut
approved these changes
Oct 28, 2024
JhontSouth
changed the base branch from
southworks/update/eslint-packages
to
main
JhontSouth
changed the base branch from
main
to
southworks/update/eslint-packages
JhontSouth
changed the base branch from
southworks/update/eslint-packages
to
main
JhontSouth
force-pushed
the
southworks/fix/eslint-issues-botbuilder-core
branch
from
8d240e8
to
9f36ee3
Compare
Pull Request Test Coverage Report for Build 11841648444Details
💛 - Coveralls |
JhontSouth
force-pushed
the
southworks/fix/eslint-issues-botbuilder-core
branch
from
9f36ee3
to
8d240e8
Compare
JhontSouth
changed the base branch from
main
to
southworks/update/eslint-packages
…eslint-issues-botbuilder-core
…eslint-issues-botbuilder-core
JhontSouth
force-pushed
the
southworks/fix/eslint-issues-botbuilder-core
branch
from
8d240e8
to
c155781
Compare
JhontSouth
changed the base branch from
southworks/update/eslint-packages
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses # 4684
#minor
Description
This PR fixes all the new errors and warnings incoming in the latest version of ESLint packages
Specific Changes
Testing
The following image shows the lint command running without problems in botbuilder-core.
