Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore sub dependencies checking #63

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

valentinloiseau
Copy link

Implement #30

Add an option ignore-sub-dependencies and check if a package is required in root.

@soullivaneuh
Copy link
Owner

Thanks and sorry for the delay. I'll try to give a look as soon as possible.

@soullivaneuh
Copy link
Owner

@valentinloiseau Could you please rebase your PR against the master branch?

@valentinloiseau
Copy link
Author

Rebased ✅

@soullivaneuh
Copy link
Owner

@valentinloiseau Looks like I have an issue with Travis. I'll inform you when this is fixed.

@soullivaneuh
Copy link
Owner

You may rebase once #72 is merged.

@valentinloiseau
Copy link
Author

@soullivaneuh An other issue with Travis?

@soullivaneuh
Copy link
Owner

Yes, but I don't understand this error. Happens sometimes.

Thanks for the rebase, I'll do a review later.

Copy link
Owner

@soullivaneuh soullivaneuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please complete package check tests with the root option case?

README.md Outdated
"show-links": false
}
}
}
```

* `ignore-sub-dependencies`: Shows only outdated package required in composer.json.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `ignore-sub-dependencies`: Shows only outdated package required in composer.json.
* `ignore-sub-dependencies`: Shows only outdated root packages.

We may also rename the option to something like root-packages-only to be consistent with the code naming. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll do it

@valentinloiseau
Copy link
Author

@soullivaneuh It's done

@rcerljenko
Copy link

@soullivaneuh can you address this please. It seams that @valentinloiseau has done it. :)

@valentinloiseau
Copy link
Author

@soullivaneuh ping

@dereuromark
Copy link
Contributor

You can now PR against maintained https://github.com/dereuromark/composer-versions-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants