-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to ignore sub dependencies checking #63
base: master
Are you sure you want to change the base?
Add option to ignore sub dependencies checking #63
Conversation
Thanks and sorry for the delay. I'll try to give a look as soon as possible. |
@valentinloiseau Could you please rebase your PR against the master branch? |
70fb43f
to
7bd637e
Compare
Rebased ✅ |
@valentinloiseau Looks like I have an issue with Travis. I'll inform you when this is fixed. |
You may rebase once #72 is merged. |
e6d8470
to
5fa3cc6
Compare
@soullivaneuh An other issue with Travis? |
Yes, but I don't understand this error. Happens sometimes. Thanks for the rebase, I'll do a review later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please complete package check tests with the root option case?
README.md
Outdated
"show-links": false | ||
} | ||
} | ||
} | ||
``` | ||
|
||
* `ignore-sub-dependencies`: Shows only outdated package required in composer.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `ignore-sub-dependencies`: Shows only outdated package required in composer.json. | |
* `ignore-sub-dependencies`: Shows only outdated root packages. |
We may also rename the option to something like root-packages-only
to be consistent with the code naming. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll do it
5fa3cc6
to
ded4bfc
Compare
@soullivaneuh It's done |
@soullivaneuh can you address this please. It seams that @valentinloiseau has done it. :) |
@soullivaneuh ping |
You can now PR against maintained https://github.com/dereuromark/composer-versions-check |
Implement #30
Add an option
ignore-sub-dependencies
and check if a package is required in root.