[Chess] Reduce _is_attacked call
#1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
=======================================
Coverage 79.95% 79.95%
=======================================
Files 61 61
Lines 5756 5758 +2
=======================================
+ Hits 4602 4604 +2
Misses 1154 1154 ☔ View full report in Codecov by Sentry. |
|
|
sotetsuk
changed the title
_is_attacked call_is_attacked call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
is_attackedcall is bottleneck, this PR intends to reduce it.In normal play, the number of legal action is < 200. See these extreme examples without black pieces:
206196These examples are found by black box optimization. There might be larger example but I believe 200 is quite enough.