Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mst account #925

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

updated_with_fixed_amount_of_fee

e917aed
Select commit
Loading
Failed to load commit list.
Open

Feature/mst account #925

updated_with_fixed_amount_of_fee
e917aed
Select commit
Loading
Failed to load commit list.
Soramitsu-Sonar-PR-decoration / sora2-substrate-js-library Sonarqube Results failed Dec 3, 2024 in 24s

Quality Gate failed

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 20 New Issues (is greater than 0)

Analysis Details

20 Issues

  • Bug 2 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 18 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.30% Estimated after merge)

Project ID: sora2:sora2-substrate-js-library

View in SonarQube

Annotations

Check warning on line 404 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L404

'any' overrides all other types in this union type.

Check warning on line 577 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L577

Unexpected lexical declaration in case block.

Check warning on line 594 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L594

Unexpected lexical declaration in case block.

Check warning on line 596 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L596

Unexpected lexical declaration in case block.

Check warning on line 579 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L579

Unexpected lexical declaration in case block.

Check warning on line 595 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L595

Unexpected lexical declaration in case block.

Check failure on line 239 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L239

Provide a compare function that depends on "String.localeCompare", to reliably sort elements alphabetically.

Check failure on line 929 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L929

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed.

Check warning on line 582 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L582

'assetIdHuman.code' may use Object's default stringification format ('[object Object]') when stringified.

Check failure on line 499 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L499

Refactor this function to reduce its Cognitive Complexity from 80 to the 15 allowed.

Check notice on line 897 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L897

Complete the task associated to this "TODO" comment.

Check warning on line 576 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L576

Unexpected lexical declaration in case block.

Check warning on line 591 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L591

Unexpected lexical declaration in case block.

Check notice on line 745 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L745

Complete the task associated to this "TODO" comment.

Check notice on line 725 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L725

Complete the task associated to this "TODO" comment.

Check failure on line 176 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L176

Provide a compare function that depends on "String.localeCompare", to reliably sort elements alphabetically.

Check failure on line 218 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L218

Refactor this function to reduce its Cognitive Complexity from 31 to the 15 allowed.

Check warning on line 23 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L23

Member 'pendingTxsSubject' is never reassigned; mark it as `readonly`.

Check notice on line 898 in packages/sdk/src/mst/index.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/mst/index.ts#L898

Complete the task associated to this "TODO" comment.

Check warning on line 5 in packages/sdk/src/apiAccount.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/sdk/src/apiAccount.ts#L5

Remove this unused import of 'BN'.