Fix loading new item list after adding new created element on sortable collections #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#8201 Apply fix as proposed in sonata-project#8201 (comment)
…e collections sonata-project#8201 Apply fix as proposed in sonata-project#8201 (comment)
Comment on lines
+343
to
+345
| var selections = jQuery('#{{ id }}').val().split(','); | ||
| selections.push(data.objectId); | ||
| jQuery('#{{ id }}').val(selections.filter((val) => val.length > 0).join(',')); |
There was a problem hiding this comment.
If entities use string as id, the usage of , could conflict no ?
Comment on lines
+45
to
+46
| if (str_contains($data[0], ',')) { | ||
| $event->setData(explode(',', $data[0])); |
There was a problem hiding this comment.
While it's work for your usage (with the javascript),
I assume it will introduce a bug if someone use this Extension/FormType in another situation for texte with string like
['Foo, bar']
It will become ['Foo', 'bar'] instead of staying the same...
I dunno if there is a way to avoid such thing...
There was a problem hiding this comment.
I think the correct approach here would be to have multiple hidden inputs, one for each id. Like the ModelAutocompleteType does it.
This would probably be more work, tho.
Another approach would be adding a special prefix to the value, that then can be checked.
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This Pull request closes two issues related to sortable collections as described in #8201
I am targeting this branch, because this patches an existing issue.
Closes #8201
Changelog