Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basics/realloc/poseidon #235

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ritikbhatt20
Copy link

  • added an example for realloc Poseidon program in the /basics/realloc/poseidon directory.

Note: Dynamic reallocation is currently unsupported in Poseidon's framework thus this example uses fixed-sized fields.
I have raised an issue to request support for this feature in Poseidon: [Poseidon Issue #22] (Turbin3/poseidon#22).

  • once Poseidon adds support for dynamic reallocation, will update this code accordingly to utilize the Poseidon transpiler.
  • replaced all occurrences of yarn with pnpm to maintain consistency across the project.
  • wrote tests using both the Solana Bankrun framework and Anchor's native testing framework.
  • executed pnpm fix to ensure code quality.
  • committed the pnpm-lock.yaml file to the repository.

Screenshot (568)

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. realloc basics/realloc labels Nov 15, 2024
Copy link
Contributor

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@ritikbhatt20
Copy link
Author

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates

  2. Run pnpm fix at the project root for consistent code style

  3. Ensure your implementation includes:

    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys

  5. Run cargo fmt and cargo clippy for Rust code quality

  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

gm @heyAyushh ,

I have refactored the changes according to new Poseidon Str type.. plus

I've completed the requested steps:

Merged main into my branch.
Ran pnpm fix.
Verified the implementation includes the transpiled Anchor program and TypeScript files.
Synchronized program ID
Ran cargo fmt and cargo clippy for Rust code quality.
Pushed all updates.
Please review again. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute:poseidon Adds a poseidon example contribution to the repository. realloc basics/realloc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants