Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Build Issue by Removing poetry build Command #2

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

JiantingFeng
Copy link
Contributor

@JiantingFeng JiantingFeng commented Feb 22, 2024

Problem

We've identified an issue that prevents our package from building correctly into a wheel on Windows platforms. After thorough investigation, it appears that the poetry build command, as currently utilized in our workflow file, is causing this failure due to some internal bugs within the poetry tool itself.

Solution

To resolve this issue and ensure our package can be successfully imported on Windows, I propose removing the poetry build command from our workflow file. This change has been tested and verified to allow the package to build and import correctly on Windows.

Changes Made

Removed the poetry build command from the .github/workflows/wheels.yml file.
Verification

After implementing this change, I conducted several tests to ensure:

The package successfully builds on Windows.
The package can be imported and used without any issues on Windows.

@JiantingFeng
Copy link
Contributor Author

Here poetry is only used as environment management tool, therefore it can be replaced by simpler alternative (e.g. virtualenv, conda) if needed.

@statmlben statmlben merged commit 280c263 into softmin:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants