Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove IntelliJ specific styles and push to Language Server #636

Merged
merged 5 commits into from
Nov 22, 2024
Merged

refactor: remove IntelliJ specific styles and push to Language Server #636

merged 5 commits into from
Nov 22, 2024

Conversation

DariusZdroba
Copy link
Contributor

@DariusZdroba DariusZdroba commented Nov 21, 2024 •
edited
Loading

Description

  • Removed Scss from IntelliJ, moved necessary styling to Language Server
  • Removed Scss compiling and dependency from build.gradle
  • Removed self invoked function to replace css variables with string replacement

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@DariusZdroba DariusZdroba requested a review from a team as a code owner November 21, 2024 15:01
@DariusZdroba DariusZdroba merged commit 93a8dad into master Nov 22, 2024
9 checks passed
@DariusZdroba DariusZdroba deleted the chore/unify-css-for-code branch November 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawkyZ ShawkyZ ShawkyZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariusZdroba @ShawkyZ