Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings for large error types #454

Merged

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Nov 13, 2024

This allows clippy::result_large_err on crate level to suppress warnings for:

  • error::Error::Http
  • handshake::HandshakeError::Interrupted
  • handshake::server::ErrorResponse

See #449 and its failed clippy build job
https://github.com/snapview/tungstenite-rs/actions/runs/11774982034/job/32794544956

This allows `clippy::result_large_err` on crate level to suppress warnings for:
- `error::Error::Http`
- `handshake::HandshakeError::Interrupted`
- `handshake::server::ErrorResponse`
@daniel-abramov daniel-abramov merged commit 81b9247 into snapview:master Nov 15, 2024
7 checks passed
@nickelc nickelc deleted the clippy-warnings/result_large_err branch November 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants