Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: space contract parity #529

Merged
merged 28 commits into from
Sep 6, 2023
Merged

chore: space contract parity #529

merged 28 commits into from
Sep 6, 2023

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Aug 30, 2023 •
edited
Loading

This PR aims to reproduce full compatibility with the SX-EVM implementation.

Breaking changes:

  • argument order of fn propose changes (metadata_uri moved to second position)
  • add dao_uri() getter function
  • rename cancel_proposal() to cancel
  • metadata_URI and dao_URI parameters in UpdateSettingsCalldata should now be array!['No update'] (i.e. an array of 1 felt with the value No update encoded)

Closes #504

@pscott pscott force-pushed the chore_space_contract_parity branch from a940e6f to 6bff80e Compare August 31, 2023 16:03
@pscott pscott mentioned this pull request Aug 31, 2023
Merged
@pscott pscott marked this pull request as ready for review September 4, 2023 09:29
@pscott pscott changed the title [WIP] Chore space contract parity Chore space contract parity Sep 4, 2023
@pscott pscott changed the title Chore space contract parity chore: space contract parity Sep 4, 2023
@pscott pscott requested a review from Orland0x September 4, 2023 13:04
Orland0x
Orland0x approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK.

@pscott pscott mentioned this pull request Sep 5, 2023
Closed
@Orland0x Orland0x merged commit b8844af into develop Sep 6, 2023
2 checks passed
@Orland0x Orland0x deleted the chore_space_contract_parity branch September 6, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing daoURI store
2 participants
@pscott @Orland0x