feat: upgradeability with initializer #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 16, 2023 18:21
pscott
approved these changes
Aug 18, 2023
Comment on lines
19
to
21
| assert(self._initialized.read() == false, 'Contract already initialized'); | ||
| self._initialized.write(true); | ||
| self._var.write(var); |
There was a problem hiding this comment.
could we make SpaceV2 use the reinitializable functions ? Just to make sure it can indeed be used again (not sure how storage works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #485
also closes #487 as it made sense to sort out now.