add vote_registry view function

snapshot-labs · Aug 30, 2023 · 8124467 · 8124467
1 parent aaa5b80
commit 8124467
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/starknet/src/space/space.cairo b/starknet/src/space/space.cairo
@@ -16,13 +16,9 @@ trait ISpace<TContractState> {
     fn active_voting_strategies(self: @TContractState) -> u256;
     fn next_voting_strategy_index(self: @TContractState) -> u8;
     fn proposal_validation_strategy(self: @TContractState) -> Strategy;
-    // #[view]
     fn vote_power(self: @TContractState, proposal_id: u256, choice: Choice) -> u256;
-    // #[view]
-    // fn vote_registry(proposal_id: u256, voter: ContractAddress) -> bool;
+    fn vote_registry(self: @TContractState, proposal_id: u256, voter: UserAddress) -> bool;
     fn proposals(self: @TContractState, proposal_id: u256) -> Proposal;
-    // #[view]
-    // fn get_proposal_status(proposal_id: u256) -> u8;
 
     // Owner Actions 
     fn update_settings(ref self: TContractState, input: UpdateSettingsCalldata);
@@ -745,6 +741,10 @@ mod Space {
             }
         }
 
+        fn vote_registry(self: @ContractState, proposal_id: u256, voter: UserAddress) -> bool {
+            self._vote_registry.read((proposal_id, voter))
+        }
+
         fn vote_power(self: @ContractState, proposal_id: u256, choice: Choice) -> u256 {
             self._vote_power.read((proposal_id, choice))
         }

diff --git a/starknet/src/tests/vote.cairo b/starknet/src/tests/vote.cairo
@@ -89,6 +89,7 @@ mod tests {
         ArrayTrait::<felt252>::new().serialize(ref vote_calldata);
 
         authenticator.authenticate(space.contract_address, VOTE_SELECTOR, vote_calldata);
+        assert(space.vote_registry(proposal_id, voter) == true, 'vote registry incorrect');
         assert(space.vote_power(proposal_id, Choice::For(())) == 1, 'Vote power should be 1');
         assert(space.vote_power(proposal_id, Choice::Against(())) == 0, 'Vote power should be 0');
         assert(space.vote_power(proposal_id, Choice::Abstain(())) == 0, 'Vote power should be 0');
@@ -123,6 +124,7 @@ mod tests {
         ArrayTrait::<felt252>::new().serialize(ref vote_calldata);
 
         authenticator.authenticate(space.contract_address, VOTE_SELECTOR, vote_calldata);
+        assert(space.vote_registry(proposal_id, voter) == true, 'vote registry incorrect');
         assert(space.vote_power(proposal_id, Choice::For(())) == 0, 'Vote power should be 0');
         assert(space.vote_power(proposal_id, Choice::Against(())) == 1, 'Vote power should be 1');
         assert(space.vote_power(proposal_id, Choice::Abstain(())) == 0, 'Vote power should be 0');
@@ -157,6 +159,7 @@ mod tests {
         ArrayTrait::<felt252>::new().serialize(ref vote_calldata);
 
         authenticator.authenticate(space.contract_address, VOTE_SELECTOR, vote_calldata);
+        assert(space.vote_registry(proposal_id, voter) == true, 'vote registry incorrect');
         assert(space.vote_power(proposal_id, Choice::For(())) == 0, 'Vote power should be 0');
         assert(space.vote_power(proposal_id, Choice::Against(())) == 0, 'Vote power should be 0');
         assert(space.vote_power(proposal_id, Choice::Abstain(())) == 1, 'Vote power should be 1');