Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instrument the number of open outgoing connections #155

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 13, 2023

This PR adds 2 new gauges to monitor the number of outgoing open connections, triggered by async requests.

Trying to debug, and confirm whether the current memory leaks issue is coming from async outgoing requests

@wa0x6e wa0x6e requested a review from Todmy August 13, 2023 16:15
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #155 (23d56a8) into master (e447595) will decrease coverage by 1.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   24.37%   22.85%   -1.53%     
==========================================
  Files          13       13              
  Lines         480      512      +32     
  Branches       23       23              
==========================================
  Hits          117      117              
- Misses        356      388      +32     
  Partials        7        7              
Files Changed Coverage Δ
src/metrics.ts 0.00% <0.00%> (ø)
src/providers/index.ts 0.00% <0.00%> (ø)
src/proxy.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@Todmy Todmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit 8d2e215 into master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants