Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC30: Add test that runs with unstable flag on #2851

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

thomas-k-cameron
Copy link
Contributor

@thomas-k-cameron thomas-k-cameron commented Jul 16, 2023

Motivation and Context

This is a sub-PR of #2615.

Changes

It adds test-with-serde check in github actions, which runs all the tests with RUSTFLAG="--cfg aws_sdk_unstable" env variable.

We need this to run tests with unstable feature enabled.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomas-k-cameron thomas-k-cameron requested review from a team as code owners July 16, 2023 11:48
@thomas-k-cameron thomas-k-cameron mentioned this pull request Jul 16, 2023
2 tasks
@thomas-k-cameron thomas-k-cameron changed the title Add RUSTFLAG="--cfg aws_sdk_unstable" to ci-scripts Add RUSTFLAG="--cfg aws_sdk_unstable" to some ci-scripts Jul 16, 2023
@rcoh rcoh requested review from a team as code owners November 14, 2023 02:21
@thomas-k-cameron thomas-k-cameron changed the title Add RUSTFLAG="--cfg aws_sdk_unstable" to some ci-scripts RFC30: Add RUSTFLAG="--cfg aws_sdk_unstable" to some ci-scripts Dec 7, 2023
@rcoh
Copy link
Collaborator

rcoh commented Dec 20, 2023

I think something like this is necessary. We probably want a single parallel task to sanity check everything with the flag enabled but do most testing with it disabled. Need to think about this. The main issue is the coverage that we're losing with the flag disabled (which is, of course, where most customers are going to be)

Maybe one CI target test-cfg-serde that runs some targeted tests of the serde behavior?

@thomas-k-cameron
Copy link
Contributor Author

@thomas-k-cameron
Copy link
Contributor Author

I got 2 errors.

  1. :jar: No valid plugin descriptors were found in META-INF/gradle-plugins from generate

and

  1. Verify client TLS configuration
output: Connecting to https://localhost:40835 with root CA bundle from /tmp/tmpybhd04f_/2: Adding root CA: O=Fake Certificate Authority (65:84:52:d7:3e:03:25:d5)DispatchFailure { source: ConnectorError { kind: Io, source: hyper::Error(Connect, Custom { kind: Other, error: Custom { kind: InvalidData, error: InvalidCertificate(NotValidForName) } }), connection: Unknown } }

Since I made no changes to both jobs, I have no idea where it's coming from :(
I don't think my changes are causing them.

@thomas-k-cameron thomas-k-cameron changed the title RFC30: Add RUSTFLAG="--cfg aws_sdk_unstable" to some ci-scripts RFC30: Add test that runs with unstable flag on May 2, 2024
@thomas-k-cameron
Copy link
Contributor Author

I think this one's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants