-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soften calibration tolerance #2423
Merged
Alexander-Sol
merged 14 commits into
smith-chem-wisc:master
from
trishorts:softenCalibrationTolerance
Oct 18, 2024
Merged
Soften calibration tolerance #2423
Alexander-Sol
merged 14 commits into
smith-chem-wisc:master
from
trishorts:softenCalibrationTolerance
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2423 +/- ##
==========================================
+ Coverage 93.67% 93.72% +0.05%
==========================================
Files 141 141
Lines 21925 21863 -62
Branches 3007 2999 -8
==========================================
- Hits 20539 20492 -47
+ Misses 934 921 -13
+ Partials 452 450 -2
|
trishorts
requested review from
Alexander-Sol,
pcruzparri,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
October 15, 2024 12:36
Alexander-Sol
approved these changes
Oct 17, 2024
nbollis
approved these changes
Oct 18, 2024
zhuoxinshi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the calculation of q-value in release 1.0.6 made it challenging for some files to have enough PSMs to support calibration. This PR does nothing to help with that problem. Analysis demonstrated that repeated calibration and adjusting the cutoff to worse q-value tolerances did essentially nothing to improve calibration. This PR simply streamlines the process, eliminating the multi step procedure to select psms for calibration.