Skip to content

Supporting richer suffixes for address syntax #118

Supporting richer suffixes for address syntax

Supporting richer suffixes for address syntax #118

Triggered via pull request October 14, 2024 21:55
Status Success
Total duration 45s
Artifacts

rust.yml

on: pull_request
Ensure rustfmt is happy
4s
Ensure rustfmt is happy
Lint the codebase with clippy
22s
Lint the codebase with clippy
Check doc links are valid
21s
Check doc links are valid
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
this loop could be written as a `while let` loop: src/exec/addr.rs#L97
warning: this loop could be written as a `while let` loop --> src/exec/addr.rs:97:9 | 97 | / loop { 98 | | match it.peek() { 99 | | Some('-' | '+') => { 100 | | let a = AddrBase::parse(it)?; ... | 107 | | } 108 | | } | |_________^ help: try: `while let Some('-' | '+') = it.peek() { .. }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop note: the lint level is defined here --> src/lib.rs:3:5 | 3 | clippy::complexity, | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::while_let_loop)]` implied by `#[warn(clippy::complexity)]`
the borrowed expression implements the required traits: src/editor/mod.rs#L242
warning: the borrowed expression implements the required traits --> src/editor/mod.rs:242:49 | 242 | _ = std::fs::write("/tmp/ad.panic", &format!("{panic_info}")); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{panic_info}")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args note: the lint level is defined here --> src/lib.rs:5:5 | 5 | clippy::style, | ^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::style)]`
this loop could be written as a `while let` loop: src/exec/addr.rs#L97
warning: this loop could be written as a `while let` loop --> src/exec/addr.rs:97:9 | 97 | / loop { 98 | | match it.peek() { 99 | | Some('-' | '+') => { 100 | | let a = AddrBase::parse(it)?; ... | 107 | | } 108 | | } | |_________^ help: try: `while let Some('-' | '+') = it.peek() { .. }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop note: the lint level is defined here --> src/lib.rs:3:5 | 3 | clippy::complexity, | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::while_let_loop)]` implied by `#[warn(clippy::complexity)]`
the borrowed expression implements the required traits: src/editor/mod.rs#L242
warning: the borrowed expression implements the required traits --> src/editor/mod.rs:242:49 | 242 | _ = std::fs::write("/tmp/ad.panic", &format!("{panic_info}")); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{panic_info}")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args note: the lint level is defined here --> src/lib.rs:5:5 | 5 | clippy::style, | ^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::style)]`
Lint the codebase with clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lint the codebase with clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/