Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selfie ViewModel Tests #258

Draft
wants to merge 7 commits into
base: selfie-capture-sensory-feedback
Choose a base branch
from

Conversation

tobitech
Copy link
Contributor

@tobitech tobitech commented Nov 21, 2024

Story: https://app.shortcut.com/smileid/story/13080/

Summary

  • Add test coverage to SelfieViewModelV2

Known Issues

N/A.

Test Instructions

Run all tests inside SelfieViewModelTests.swift and all should pass.

Screenshot

N/A.

@tobitech tobitech self-assigned this Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

Warnings
⚠️

Example/Tests/SelfieCapture/FaceDetectorTests.swift#L52 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/FaceDetectorTests.swift#L63 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/FaceDetectorTests.swift#L85 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/FaceDetectorTests.swift#L153 - Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

⚠️

Example/Tests/SelfieCapture/SelfieViewModelTests.swift#L61 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/SelfieViewModelTests.swift#L74 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/SelfieViewModelTests.swift#L81 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/SelfieViewModelTests.swift#L88 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Example/Tests/SelfieCapture/SelfieViewModelTests.swift#L104 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/SmileID/Classes/FaceDetector/SelfieQualityDetectorWrapper.swift#L6 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/SmileID/Classes/FaceDetector/SelfieQualityDetectorWrapper.swift#L11 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift#L197 - TODOs should be resolved (Use mouth deformation as an al...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L159 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L184 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

Generated by 🚫 Danger Swift against 099c41a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant