Fix: allow commas in kubelet arg values #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Updating jinja2 (3.1.2 -> 3.1.3) • Updating markdown (3.5.1 -> 3.5.2) • Updating google-auth (2.26.1 -> 2.26.2) • Updating pycryptodome (3.19.1 -> 3.20.0)
…reenshots everywhere
…elet args tab for k3s tabbedcontent
|
test is failing on k3s, but that's due to a lack of isolation of the environments, I think. Will investigate that in a separate issue/PR |
jessebot
added a commit
that referenced
this pull request
May 15, 2024
…let args into their own tab (#135) * don't create a list if there's = in the kubelet-arg * adding more comprehensive kubeletConfig class * clean up k3s/k3d borders for last tui block * tui: clean up tabs and borders for k3s.yaml and kubelet args specifically * change trigger to tab, and add k3s kubelet + k3s k3s_yaml as potential tabs * fix issue where we kept writing the kubelet arg even if it already existed * specify an id for the kubelet widget so that we can generate rows for it * update dependencies: • Updating jinja2 (3.1.2 -> 3.1.3) • Updating markdown (3.5.1 -> 3.5.2) • Updating google-auth (2.26.1 -> 2.26.2) • Updating pycryptodome (3.19.1 -> 3.20.0) * add doc strings for action_launch_new_option_modal and method * switch to max-pods everywhere instead of max_pods * updating docs example of configfile * refactor DistroConfigScreen.action_launch_new_option_modal, update screenshots everywhere * update alt text for distro_config_screen.svg in docs * update test-smol-k8s-lab to run on pull request instead of pushes * add tests for k3s * remove branches-ignore: ['main'] for test smol-k8s-lab job * if kubelet-arg is new option for k3s_yaml, exit and switch to the kubelet args tab for k3s tabbedcontent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132 by adding tabs to the k3s and k3d screen to specifically add kubelet args, instead of accepting them as part of the k3s.yaml file. New TUI screenshot:
The button at the bottom of the third box that says "➕ K3s Option" now can distinguish which tab and section of the yaml it needs to update. When a user enters
kubelet-argas a new option for thek3s.yamltab, it will gracefully just switch to the correct kubelet args tab.