Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to gtk4 #561

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

port to gtk4 #561

wants to merge 10 commits into from

Conversation

deltragon
Copy link
Collaborator

@deltragon deltragon commented Jan 2, 2024

Based on #560, will rebase the first two commits away once that is merged.
Needs #558 for the trayicon - with the trayicon plugin disabled, this can be tested as-is.

The changes in the .glade xml files are rather noisy, they were partially done using gtk-builder-tool.
I mostly made sure that things still looked correct visually after running the tool.

Opening this as draft for now, as it relies on the two PRs above. Additionally, this is a rather big PR, and I'd like to split it into things that are backwards compatible with gtk3 (like most changes in the .glade files) and things that are not.
It also likely needs some changes in the configurations/dependencies.

Fixes #367.
Fixes #521.
Fixes #473.

@archisman-panigrahi
Copy link
Collaborator

@deltragon Is this ready?

@deltragon
Copy link
Collaborator Author

@archisman-panigrahi No, it needs #560 and #558 to be merged first.

@slgobinath
Copy link
Owner

Thanks @deltragon

Can someone help testing these PRs? If anyone confirms the changes, I'll merge them and release.

@deltragon
Copy link
Collaborator Author

This is almost ready now.

I have tested this on multiple platforms, and found one more issue which is in #655 and can be merged before the switch to Gtk4.

Additionally, I split out #651 into a separate PR to be merged after this - that one is simply an improvement on Wayland enabled by Gtk4.

While in theory, there are changes to the glade files that should be compatible with Gtk3 as well - those changes are still very big and would need to be tested manually, so we don't really gain much by splitting them out.
In addition, the only risk would be small UI/styling differences, where the update to Gtk4 on its own is the biggest cause of change anyways.
So I think we should just merge this as one, once #655 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants