-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to gtk4 #561
base: master
Are you sure you want to change the base?
port to gtk4 #561
Conversation
@deltragon Is this ready? |
@archisman-panigrahi No, it needs #560 and #558 to be merged first. |
Thanks @deltragon Can someone help testing these PRs? If anyone confirms the changes, I'll merge them and release. |
This is almost ready now. I have tested this on multiple platforms, and found one more issue which is in #655 and can be merged before the switch to Gtk4. Additionally, I split out #651 into a separate PR to be merged after this - that one is simply an improvement on Wayland enabled by Gtk4. While in theory, there are changes to the glade files that should be compatible with Gtk3 as well - those changes are still very big and would need to be tested manually, so we don't really gain much by splitting them out. |
Based on #560, will rebase the first two commits away once that is merged.Needs #558 for the trayicon - with the trayicon plugin disabled, this can be tested as-is.The changes in the .glade xml files are rather noisy, they were partially done using gtk-builder-tool.
I mostly made sure that things still looked correct visually after running the tool.
Opening this as draft for now, as it relies on the two PRs above. Additionally, this is a rather big PR, and I'd like to split it into things that are backwards compatible with gtk3 (like most changes in the .glade files) and things that are not.
It also likely needs some changes in the configurations/dependencies.
Fixes #367.
Fixes #521.
Fixes #473.