Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual backport of https://github.com/vitessio/vitess/pull/17300/ #570

Merged

Conversation

ejortegau
Copy link
Collaborator

This PR is a manual backport of upstream vitessio#17300
The information below is a copy of what the description of the upstream PR

Description

This PR addresses fixes issues in PRS & ERS preference for tablets that are not taking backups. It does away with redundant field definitions in some of the proto messages and addresses segfault that could take place during ERS.

Related Issue(s)

vitessio#17299

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
@github-actions github-actions bot added this to the v15.0.5 milestone Dec 2, 2024
Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
@ejortegau ejortegau marked this pull request as ready for review December 2, 2024 17:25
@ejortegau ejortegau requested a review from a team as a code owner December 2, 2024 17:25
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and stamp it as Deepthi has approved the upstream PR. Thank you!

@ejortegau ejortegau merged commit a03067d into slack-15.0 Dec 3, 2024
197 checks passed
@ejortegau ejortegau deleted the ejortegau/fixes_reparents_avoid_hosts_taking_backup branch December 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants