slack-15.0: add topo/healthcheck flags to vttablet for txthrottler
#560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
commented
Nov 15, 2024
| @@ -165,6 +165,7 @@ func init() { | |||
| } | |||
|
|
|||
| servenv.OnParseFor("vtctld", registerWebUIFlags) | |||
| servenv.OnParseFor("vttablet", registerWebUIFlags) | |||
There was a problem hiding this comment.
registerWebUIFlags is a terrible func name, all but 1 flag are not web UI related. But wasn't me 🤦
timvaillancourt
deleted the
vttablet-topo_read_concurrency.slack-15.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds important flags for tuning topo/discovery behaviour in
vttablet, which will benefittxthrottlerWith this PR I suggest we:
--topo_read_concurrencyto4, equal to cells (from32😬)--tablet_refresh_interval duration(currently1m)--tablet_refresh_known_tabletsto cache records--healthcheck-dial-concurrencyto4-8-ishcc @ejortegau
Related Issue(s)
Checklist
Deployment Notes