Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the binary protos #25

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Commits on Apr 19, 2024

  1. Inline the binary protos

    protoc-gen-hack/plugin.go was generating the gzipped binary
    ProtoDescriptorProto and returning it to protoc so we could
    save it to a file. protoc was warning us about having those
    file's content being invalid UTF-8.
    
    Unfortunately newer protoc binary reject files with such a
    ayload. We do want to keep the binary FileDescriptorProto
    logic for servers that can send the binary descriptor to
    their clients but we can inline it in each generated file.
    
    While we don't need to gzip the content anymore, I kept
    this logic as we were generating large binary strings
    in Hacklang.
    jchaffraix-slack committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f50a83b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    ec272d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    316b608 View commit details
    Browse the repository at this point in the history