[do not merge] Force CI to run #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ubuntu-18.04` image has been unsupported for more than a year and there are no workers on GitHub that runs it. This means that our CI just waits for one worker and times out. The solution is to switch to a custom Docker image based on the HHVM public images and move all the tests run into the new image. To avoid spinning multiple containers (and recomputing some of the cached bazel actions), all tests were moved into a new script `ci/run_tests.sh`.
This fixes compilation with more modern versions of Bazel that consider some rules in io_bazel_rules_go to be broken.
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks commits from both #22 and #23 so we can run CI for both of these combined.