build: allow the test task to pass if no tests can be found #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![slack-samples[bot]](https://avatars.githubusercontent.com/in/894979?s=60&v=4){kind=small}
zimeg
requested changes
Oct 31, 2024
| @@ -28,6 +28,6 @@ | |||
| }, | |||
| "lock": false, | |||
| "tasks": { | |||
| "test": "deno fmt --check && deno lint && deno test --allow-read" | |||
| "test": "deno fmt --check && deno lint && deno test --allow-read --allow-none" | |||
There was a problem hiding this comment.
Noticed this was removed to be compatible with Deno 2 - super casual mention @filmaj
I think this is a good change to share across other samples (removing the flag from deno.jsonc) but will want to make sure we have tests in place or can otherwise avoid problems in CI before fanning out this removal 👻
There was a problem hiding this comment.
More context on the allow-none flag: denoland/deno#24752
There was a problem hiding this comment.
Super interesting, thanks for sharing! It seems like --permit-no-files is the alternative, but I'm still hoping that we can include a test with all of our samples 😉
zimeg
changed the title
zimeg
changed the title
|
🔍 For fast reference: https://github.com/orgs/slack-samples/repositories?q=visibility%3Apublic+deno |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically synchronizing changes to the
deno.jsoncfile across all samples