Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch] Completed RTM Info #819

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Patch] Completed RTM Info #819

wants to merge 5 commits into from
+23 −5

Conversation

KarimNahas
Copy link
Contributor

PR Content:

  • Added missing information collected from rtm.start (info is generated when creating a new rtm using RTMOptionUseStart option)

kanata2
kanata2 reviewed Dec 9, 2020
View reviewed changes
info.go Outdated Show resolved Hide resolved
@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Feb 14, 2021
@KarimNahas
Copy link
Contributor Author

@kanata2
I've rebased the code and added a description as per your review (I tried to be as explicit as possible).
Also made sure that all test are passing.
Tell me if any other modifications are needed.

@KarimNahas KarimNahas requested a review from kanata2 March 25, 2021 13:35
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 Awaiting requested review from kanata2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarimNahas @kanata2