Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate JSON converter #73

Merged
merged 4 commits into from
Feb 26, 2024
Merged

feat: generate JSON converter #73

merged 4 commits into from
Feb 26, 2024

Conversation

skarllot
Copy link
Owner

@skarllot skarllot commented Feb 26, 2024

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • Generate JSON converter supporting EnumMember and JsonPropertyName attributes

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@skarllot skarllot added enhancement New feature or request .NET Pull requests that update .net code labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (7cab1ff) to head (b7ce8ea).

❗ Current head b7ce8ea differs from pull request most recent head 33aec16. Consider uploading reports for the commit 33aec16 to get more accurate results

Files Patch % Lines
...es.Abstractions/JsonConverterGeneratorAttribute.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main     #73   +/-   ##
====================================
  Coverage      0   0.00%           
====================================
  Files         0       1    +1     
  Lines         0       2    +2     
====================================
- Misses        0       2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fgodoy-lepaho
fgodoy-lepaho previously approved these changes Feb 26, 2024
fgodoy-lepaho
fgodoy-lepaho previously approved these changes Feb 26, 2024
@skarllot skarllot merged commit 2afb0ed into main Feb 26, 2024
4 checks passed
@skarllot skarllot deleted the json-converter branch February 26, 2024 02:49
@skarllot skarllot linked an issue Feb 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generating JsonConverter
2 participants