fix: Not allow parse numeric values to description

skarllot · Oct 6, 2024 · e22bcf8 · e22bcf8
1 parent 2e5eabc
commit e22bcf8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 50 deletions.
diff --git a/gen/EnumUtilities.Generators/CodeWriters/EnumFactoryWriter.cs b/gen/EnumUtilities.Generators/CodeWriters/EnumFactoryWriter.cs
@@ -3172,7 +3172,7 @@ private void WriteDescriptionBlock()
 
         #line 63 "C:\Users\skarl\source\repos\github\skarllot\EnumUtilities\gen\EnumUtilities.Generators\CodeWriters\Factory\DescriptionBlock.ttinclude"
 
-        WriteTryParse(x => x.Description, "Description", "description");
+        WriteTryParse(x => x.Description, "Description", "description", allowNumbers: false);
     }
 
 

diff --git a/gen/EnumUtilities.Generators/CodeWriters/Factory/DescriptionBlock.ttinclude b/gen/EnumUtilities.Generators/CodeWriters/Factory/DescriptionBlock.ttinclude
@@ -61,6 +61,6 @@
     }
 
 <#+
-        WriteTryParse(x => x.Description, "Description", "description");
+        WriteTryParse(x => x.Description, "Description", "description", allowNumbers: false);
     }
 #>
diff --git a/...tiesGenerator/Raiqub.Generators.EnumUtilities.IntegrationTests.Models.MyEnum2Factory.g.cs b/...tiesGenerator/Raiqub.Generators.EnumUtilities.IntegrationTests.Models.MyEnum2Factory.g.cs
@@ -668,33 +668,9 @@ private static bool TryParseDescription(ReadOnlySpan<char> description, StringCo
         {
             if (!description.IsEmpty)
             {
-                char c = description[0];
-                if (char.IsWhiteSpace(c))
-                {
-                    description = description.TrimStart();
-                    if (description.IsEmpty)
-                    {
-                        goto ParseFailure;
-                    }
-
-                    c = description[0];
-                }
-
-                if ((c < '0' || c > '9') && c != '-' && c != '+')
-                {
-                    return TryParseNonNumericDescription(description, comparisonType, throwOnFailure, out result);
-                }
-
-                bool success = EnumNumericParser.TryParse(description, out result);
-                if (success)
-                {
-                    return true;
-                }
-
                 return TryParseNonNumericDescription(description, comparisonType, throwOnFailure, out result);
             }
 
-            ParseFailure:
             if (throwOnFailure)
             {
                 ThrowHelper.ThrowInvalidEmptyParseArgument(nameof(description));

diff --git a/...nerator/Raiqub.Generators.EnumUtilities.IntegrationTests.Models.PaymentMethodFactory.g.cs b/...nerator/Raiqub.Generators.EnumUtilities.IntegrationTests.Models.PaymentMethodFactory.g.cs
@@ -668,33 +668,9 @@ private static bool TryParseDescription(ReadOnlySpan<char> description, StringCo
         {
             if (!description.IsEmpty)
             {
-                char c = description[0];
-                if (char.IsWhiteSpace(c))
-                {
-                    description = description.TrimStart();
-                    if (description.IsEmpty)
-                    {
-                        goto ParseFailure;
-                    }
-
-                    c = description[0];
-                }
-
-                if ((c < '0' || c > '9') && c != '-' && c != '+')
-                {
-                    return TryParseNonNumericDescription(description, comparisonType, throwOnFailure, out result);
-                }
-
-                bool success = EnumNumericParser.TryParse(description, out result);
-                if (success)
-                {
-                    return true;
-                }
-
                 return TryParseNonNumericDescription(description, comparisonType, throwOnFailure, out result);
             }
 
-            ParseFailure:
             if (throwOnFailure)
             {
                 ThrowHelper.ThrowInvalidEmptyParseArgument(nameof(description));