1545 state locking final - dont review yet #2024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimalit
reviewed
Nov 22, 2024
| std::mutex m_receivedMutex; | ||
|
|
||
|
|
||
| list< dev::eth::Transaction > m_broadcastQueue; |
There was a problem hiding this comment.
We need to carefully test it, because introduction of broadcast queue will break following calls in TransactionQueue:
- drop()
- waiting
- knownTransactions
- isTransactionKnown
- maxNonce
- maxCurrentNonce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief summary of your changes here. Replace this comment with your summary.
Tests
Describe how you tested the changes made in this pull request. Include specific tests you have added. Replace this comment with your testing methodology.
Performance Impact
Describe any potential impact on performance due to your changes. Include any benchmarks you performed, if applicable, and compare the results with and without your changes. Replace this comment with your performance analysis.