-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corrupt json #7
base: master
Are you sure you want to change the base?
Conversation
Tested on kibana locally this import succeeds and all the visualisations appear to work as expected. It's difficult to know if these are the latest versions of the visualisations as the authors intended due to the complexity of the nested json. As such this is more of a "best guess" of what the json should be.
|
I think there's definitely some JSON missing, for instance, the "Test FLOW" visualisation, as shown in the image on the README for this example, is missing completely in original and in this pull request. |
Thanks @Alan01252 are you referring to the Vega flows or the IP Flow Diagrams? IP Flow Diagram requires an additional Kibana plugin and can't be done with Vega juet yet. |
Yep, that's the one I was referring to! Sorry, my misunderstanding! |
@Alan01252 here's what was used for the demo, unfortunately no time to maintain it: https://github.com/lmangani/kibana_diagram |
@Imangani that's perfect thanks you very much! |
Tested on kibana locally this import succeeds and all the visualisations
appear to work as expected.
It's difficult to know if these are the latest versions of the
visualisations as the authors intended due to the complexity of the
nested json. As such this is more of a "best guess" of what the json
should be.
fixes #6