Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heplify-server gets some 2024 love #153

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

systemcrash
Copy link
Contributor

This includes an accumulation of tweaks which have kept my stack going. Some necessary to run contemporary Grafana/Loki etc versions.

I pointed homer-webapp image from docker repo to GHCR.

A couple of config changes for Loki were spawned from this grafana/loki#2018 (comment) so I took the liberty of enabling Loki changes (including WAL) where Loki is configured, and giving that a volume path. WAL is good to have, altho I don't think new users starting with these stack compose kits will encounter the upgrade problem I did.

Happy Easter 🐣 🥚 🌴

@adubovikov
Copy link
Member

Thank you so much! Happy Eastern!

@lmangani
Copy link
Member

Thanks for the contribution @systemcrash! We truly appreciate it 🥇
As you might know, we develop a drop-in compatible LGTM replacement (qryn) and HOMER 10 is based on it, so having loki as part of this or any other recipe doesn't make sense anymore. Would you be ok filtering the loki parts out of the PR so we can merge this? If that's unviable, I'll merge and proceed with replacing.
Thanks once again and happy easter!

@systemcrash
Copy link
Contributor Author

So, just drop the loki: changes, because loki is leaving, and force push? Sure.

Did not know.

@systemcrash
Copy link
Contributor Author

I figure that if loki goes, promtail does too. So everything except for the delete can go.

@lmangani
Copy link
Member

lmangani commented Apr 1, 2024

@systemcrash nothing really goes when it comes to clients - qryn is 100% loki compatible. We just don't use Grafana Loki, but everything else remains as powerful as ever.

@systemcrash
Copy link
Contributor Author

@systemcrash nothing really goes when it comes to clients - qryn is 100% loki compatible. We just don't use Grafana Loki, but everything else remains as powerful as ever.

My point being that promtail is part of Loki. So if (Grafana) Loki is no longer used, then having promtail config is kind of pointless :)

@lmangani
Copy link
Member

lmangani commented Apr 1, 2024

@systemcrash

My point being that promtail is part of Loki.

And qryn is 100% compatible with it. Promtail and any other Loki client continues to work.

So if (Grafana) Loki is no longer used, then having promtail config is kind of pointless :)

qryn is 100% compatible with Loki. Grafana as a client, and all LogQL queries continue working as before.

We're just swapping Loki for qryn, without any changes required to any client or integration

You can read up about qryn here: https://github.com/metrico/qryn

@systemcrash
Copy link
Contributor Author

is this ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants