feat: add FitsFile::file_path method to access FitsFile file path
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
changed the title
FitsFile::file_path method to access FitsFile file path
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
d3v-null
added a commit
to MWATelescope/mwa_hyperdrive
that referenced
this pull request
Oct 31, 2024
d3v-null
added a commit
to MWATelescope/mwalib
that referenced
this pull request
Oct 31, 2024
Merged
simonrw
added a commit
that referenced
this pull request
Oct 31, 2024
## 🤖 New release * `fitsio`: 0.21.5 -> 0.21.6 (✓ API compatible changes) * `fitsio-sys`: 0.5.3 -> 0.5.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `fitsio` <blockquote> ## [0.21.6](fitsio-v0.21.5...fitsio-v0.21.6) - 2024-10-31 ### Added - add `FitsFile::file_path` method to access `FitsFile` file path ([#367](#367)) ### Other - Allow needless-lifetimes ([#363](#363)) </blockquote> ## `fitsio-sys` <blockquote> ## [0.5.4](fitsio-sys-v0.5.3...fitsio-sys-v0.5.4) - 2024-10-31 ### Other - *(deps)* update bindgen requirement from 0.69 to 0.70 in /fitsio-sys in the cargo-packages group ([#357](#357)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a method to access the file path of the
FitsFile.During my investigation I found that there was no reason to make it optional. Given this, I have made the field/function return non-optional as well.
Also: it is stored as a
PathBufinternally, and inherently refers to a path on disk, so let's return aPathin that case.Closes #366