Merge pull request #202 from creative-commoners/pulls/6/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 8a66091 · 8a66091
2 parents a8628b5 + a8f9184
commit 8a66091
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/CredentialRepositoryProviderTrait.php b/src/CredentialRepositoryProviderTrait.php
@@ -19,7 +19,7 @@ trait CredentialRepositoryProviderTrait
      */
     protected function getCredentialRepository(
         StoreInterface $store,
-        RegisteredMethod $registeredMethod = null
+        ?RegisteredMethod $registeredMethod = null
     ): CredentialRepository {
         $state = $store->getState();
 

diff --git a/src/VerifyHandler.php b/src/VerifyHandler.php
@@ -165,7 +165,7 @@ public function getComponent(): string
      */
     protected function getCredentialRequestOptions(
         StoreInterface $store,
-        RegisteredMethod $registeredMethod = null,
+        ?RegisteredMethod $registeredMethod = null,
         $reset = false
     ): PublicKeyCredentialRequestOptions {
         $state = $store->getState();

diff --git a/tests/RegisterHandlerTest.php b/tests/RegisterHandlerTest.php
@@ -175,8 +175,8 @@ public function testRegister(
         $mockResponse,
         $expectedResult,
         $expectedCredentialCount,
-        callable $responseValidatorMockCallback = null,
-        callable $storeModifier = null
+        ?callable $responseValidatorMockCallback = null,
+        ?callable $storeModifier = null
     ) {
         /** @var RegisterHandler&MockObject $handlerMock */
         $handlerMock = $this->getMockBuilder(RegisterHandler::class)

diff --git a/tests/VerifyHandlerTest.php b/tests/VerifyHandlerTest.php
@@ -129,7 +129,7 @@ public function testVerifyReturnsErrorWhenRequiredInformationIsMissing()
     public function testVerify(
         $mockResponse,
         $expectedResult,
-        callable $responseValidatorMockCallback = null
+        ?callable $responseValidatorMockCallback = null
     ) {
         /** @var VerifyHandler&MockObject $handlerMock */
         $handlerMock = $this->getMockBuilder(VerifyHandler::class)