Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Explicity mark nullable parameters for PHP 8.4 #483

Merged
merged 2 commits into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
361a4b2
API Explicity mark nullable parameters for PHP 8.4
emteknetnz Nov 28, 2024
5ff41a2
API Make parameter non-optional for PHP 8.4
emteknetnz Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DataDifferencer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class DataDifferencer extends ModelData
* @param DataObject $fromRecord
* @param DataObject $toRecord
*/
public function __construct(DataObject $fromRecord = null, DataObject $toRecord = null)
public function __construct(?DataObject $fromRecord = null, ?DataObject $toRecord = null)
{
$this->fromRecord = $fromRecord;
$this->toRecord = $toRecord;
Expand Down
4 changes: 2 additions & 2 deletions src/Versioned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ protected function updateInheritableQueryParams(&$params)
* @param DataQuery|null $dataQuery
* @throws InvalidArgumentException
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{
if (!$dataQuery) {
return;
Expand Down Expand Up @@ -895,7 +895,7 @@ protected function isTableVersioned($table)
* @param DataQuery $dataQuery
* @param DataObject $dataObject
*/
protected function augmentLoadLazyFields(SQLSelect &$query, DataQuery &$dataQuery = null, $dataObject)
protected function augmentLoadLazyFields(SQLSelect &$query, ?DataQuery &$dataQuery, $dataObject)
{
// The VersionedMode local variable ensures that this decorator only applies to
// queries that have originated from the Versioned object, and have the Versioned
Expand Down
Loading