API Make parameter non-optional for PHP 8.4

silverstripe · Dec 1, 2024 · 86c1aa2 · 86c1aa2
1 parent b690f59
commit 86c1aa2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Forms/DataObjectVersionFormFactory.php b/src/Forms/DataObjectVersionFormFactory.php
@@ -91,7 +91,7 @@ public function isReadonlyFormType(array $context)
         return in_array($this->getFormType($context), $this->config()->get('readonly_types') ?? []);
     }
 
-    protected function getFormFields(?RequestHandler $controller = null, $name, $context = [])
+    protected function getFormFields(?RequestHandler $controller, $name, $context = [])
     {
         $record = $context['Record'];
         /** @var FieldList $fields */
@@ -157,7 +157,7 @@ protected function removeSelectedRightTitles(FieldList $fields)
         }
     }
 
-    protected function getFormActions(?RequestHandler $controller = null, $formName, $context = [])
+    protected function getFormActions(?RequestHandler $controller, $formName, $context = [])
     {
         $actions = FieldList::create();
         $this->invokeWithExtensions('updateFormActions', $actions, $controller, $formName, $context);