Add PreformattedEchoHandler
#8930
Conversation
cherry-picked from 4c3f3e6
Also make logger work for stdout
Time constraints. This will be rewritten, there's an issue for this here: #5542 |
Co-Authored-By: bergice <bergice@users.noreply.github.com>
|
Yep, I've authored that error handler - it's a hack, and marked as |
| { | ||
| if ($logger = Injector::inst()->get(LoggerInterface::class)) { | ||
| if (Director::is_cli()) { | ||
| $logger->pushHandler(new StreamHandler('php://stdout')); |
There was a problem hiding this comment.
LoggerInterface doesn't have pushHandler methods
There was a problem hiding this comment.
Yeah, I think this is one of those cases where we squint a bit, and just assume that people will not apply loggers other than Monolog for now. We're effectively using LoggerInterface as a global singleton here, since @bergice other PR on queuedjobs is configuring that singleton with additional handlers, so both of these are assuming to work off the same instance. It's pretty messy, but the answer is not to use log handlers here at all, but rather Symfony Console.
| @@ -23,6 +28,8 @@ class MigrateFileTask extends BuildTask | |||
|
|
|||
| public function run($request) | |||
| { | |||
| $this->addLogHandlers(); | |||
There was a problem hiding this comment.
could we do that in the constructor rather than the run method?
| */ | ||
| protected function addLogHandlers() | ||
| { | ||
| if ($logger = Injector::inst()->get(LoggerInterface::class)) { |
There was a problem hiding this comment.
could we have a prototype specialisation, like
Psr\Log\LoggerInterface.monolog:
type: prototype
class: Monolog\Logger
rather than taking the service and mutate its global state in here?
| protected function addLogHandlers() | ||
| { | ||
| if ($logger = Injector::inst()->get(LoggerInterface::class)) { | ||
| if (Director::is_cli()) { |
There was a problem hiding this comment.
might worth having a separate logger class implementation rather than encoding this logic in here
|
lol, too late :) |
cherry-picked from 4c3f3e6