Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate legacy thumbnails (fixes #235) #242

Merged
merged 7 commits into from
May 1, 2019
Merged

Migrate legacy thumbnails (fixes #235) #242

merged 7 commits into from
May 1, 2019

Commits on Apr 29, 2019

  1. NEW Migrate legacy thumbnails (fixes silverstripe#235) 

    Legacy thumbnails weren't migrated, but rather re-created on demand.
This increases disk space requirements, CPU resources,
and wait times for users (since most of these are generated inline with PHP responses).
    @chillu
    chillu committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    b26d4e0 View commit details
    Browse the repository at this point in the history

  2. Test generated file location

    @chillu
    chillu committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    260effe View commit details
    Browse the repository at this point in the history

  3. NEW Removed migrate_legacy_file support 

    For the vast majority of sites, you really don't want to run your file migration as part of dev build.
The step is involved enough to warrant it's own task.
I don't think this is an API change, since the setting won't have affect
for anyone who has already enabled it - they would've already done the one-off migration.
    @chillu
    chillu committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    d8d9bb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. Fix namespace

    @chillu
    chillu committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    c457db9 View commit details
    Browse the repository at this point in the history

  2. Fix test for later revision of file helper implementations

    @chillu
    chillu committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    9b74fa1 View commit details
    Browse the repository at this point in the history

  3. Removed protected thumbs test 

    See https://github.com/silverstripe/silverstripe-assets/pull/242/files#r279615136
    @chillu
    chillu committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    fa4b14c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. BUG Fix liniting issues

    Maxime Rainville committed May 1, 2019
    Configuration menu
    Copy the full SHA
    29b6625 View commit details
    Browse the repository at this point in the history