Merge branch '2' into 3

code/Controller/AssetAdmin.php

@@ -1427,9 +1427,12 @@ public function generateThumbnails(File $file, $thumbnailLinks = false)
 
     /**
      * Action handler for adding pages to a campaign
+     *
+     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
      */
     public function addtocampaign(array $data, Form $form): HTTPResponse
     {
+        Deprecation::noticeWithNoReplacment('2.4.0');
         $id = $data['ID'];
         $record = File::get()->byID($id);
 
@@ -1451,9 +1454,11 @@ public function addtocampaign(array $data, Form $form): HTTPResponse
      *
      * @param HTTPRequest $request
      * @return Form
+     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
      */
     public function addToCampaignForm($request)
     {
+        Deprecation::noticeWithNoReplacment('2.4.0');
         // Get ID either from posted back value, or url parameter
         $id = $request->param('ID') ?: $request->postVar('ID');
         return $this->getAddToCampaignForm($id);
@@ -1462,9 +1467,11 @@ public function addToCampaignForm($request)
     /**
      * @param int $id
      * @return Form|HTTPResponse
+     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
      */
     public function getAddToCampaignForm($id)
     {
+        Deprecation::noticeWithNoReplacment('2.4.0');
         // Get record-specific fields
         $record = File::get()->byID($id);