Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update deprecation docs #599

Merged
merged 1 commit into from
Oct 21, 2024
Merged

DOC Update deprecation docs #599

merged 1 commit into from
Oct 21, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 16, 2024
Closed
4 tasks
GuySartorelli
GuySartorelli approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after code PR (linting failure is unrelated)

GuySartorelli
GuySartorelli requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I do have one change request

en/06_Upgrading/07_Deprecations.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/depr-docs branch 2 times, most recently from 5e263be to f0093ba Compare October 17, 2024 03:26
GuySartorelli
GuySartorelli requested changes Oct 17, 2024
View reviewed changes
en/06_Upgrading/07_Deprecations.md Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 690ab43 into silverstripe:5 Oct 21, 2024
2 of 3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/depr-docs branch October 21, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli