Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded value in log message when getlogentrybyuuid fails #2282

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

bobcallaway
Copy link
Member

the UUID is specified as part of the URL which is already captured in other log messages; this as previously written failed with an Ignored key without value error because the zap logger expects "key", "value"

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner November 21, 2024 13:50
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.90%. Comparing base (488eb97) to head (3f3d4cb).
Report is 240 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/entries.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2282       +/-   ##
===========================================
- Coverage   66.46%   49.90%   -16.56%     
===========================================
  Files          92      192      +100     
  Lines        9258    24677    +15419     
===========================================
+ Hits         6153    12316     +6163     
- Misses       2359    11270     +8911     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 46.52% <0.00%> (-1.03%) ⬇️
unittests 41.92% <0.00%> (-5.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bobcallaway bobcallaway merged commit 92584b7 into sigstore:main Nov 21, 2024
15 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants