-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flatten #34
add flatten #34
Conversation
awesome! will review tomorrow |
fixed a little bug here, but now this is working in lighthouse sigp/lighthouse#5158 Also a limitation right now is we don't have a way to nest inner types that have a subset of variants of the outer type. I think vice-versa should work though (haven't tested it). So nesting an execution payload in a block in lighthouse wouldn't benefit from this for example. |
This actually wasn't so bad to get working, I added it here: 76b67a1 |
I pushed a bugfix for an issue I noticed with using the |
I also think we want to use the last part of the path, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't spot any other issues, so I think this is good to merge!
Resolves #30