BUG/MEDIUM: rules: add redirect_url when flattening #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported that when using `redirect_url` changes were being presented when applying a plan, even though there were not any changes being made. This was due to `redirect_url` not being reset during rule flattening within `flattenRuleActions`. This commit fixes that and adds `redirect_url` to the `actionmap` within `flattenRuleActions`.
shawnps
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that when using
redirect_urlchanges were being presented when applying a plan, even though there were not any changes being made.This was due to
redirect_urlnot being reset during rule flattening withinflattenRuleActions.This commit fixes that and adds
redirect_urlto theactionmapwithinflattenRuleActions.