archive status lookup return string instead of enum to int

src/Tetrifact.Core/ArchiveProgressInfo.cs

@@ -1,5 +1,7 @@
-using System;
-
+using Newtonsoft.Json.Converters;
+using System;
+using System.Text.Json.Serialization;
+
 namespace Tetrifact.Core
 {
     /// <summary>
@@ -25,6 +27,7 @@ public class ArchiveProgressInfo
         /// <summary>
         /// 
         /// </summary>
+        [JsonConverter(typeof(JsonStringEnumConverter))]
         public PackageArchiveCreationStates State { get;set;}
 
         /// <summary>

src/Tetrifact.Core/ArchiveService.cs

@@ -138,7 +138,7 @@ public ArchiveProgressInfo GetPackageArchiveStatus(string packageId)
             if (!_fileSystem.File.Exists(archiveQueuePath))
                 return new ArchiveProgressInfo
                 {
-                    State = PackageArchiveCreationStates.Processed_ArchiveNotAvailableNotGenerated
+                    State = PackageArchiveCreationStates.Processed_ArchiveNotGenerated
                 };
 
             string progressCacheKey = this.GetArchiveProgressKey(packageId);

src/Tetrifact.Core/IArchiveService.cs

@@ -6,7 +6,7 @@ namespace Tetrifact.Core
     public interface IArchiveService
     {
         /// <summary>
-        /// Generates an archive for the given package id, sychronously. Returns when archive is generated. This method is exposed for testing purposes only, and must not tamper with archive queue. 
+        /// Generates an archive for the given package id, synchronously. Returns when archive is generated. This method is exposed for testing purposes only, and must not tamper with archive queue. 
         /// Normally it will be called from CreateNextQueuedArchive().
         /// </summary>
         /// <param name="packageId"></param>
@@ -40,11 +40,6 @@ public interface IArchiveService
         /// <summary>
         /// Returns a status code the given archive. Requesting status for a given archive will also start
         /// generating that archive.
-        /// 0 : Archive creation was started.
-        /// 1 : Archive is already started, is still in progress.
-        /// 2 : Archive is available for download.
-        /// 
-        /// throw a PackageNotFoundException if the package does not exist or is marked for delete
         /// </summary>
         /// <returns></returns>
         ArchiveProgressInfo GetPackageArchiveStatus(string packageId);
@@ -65,8 +60,18 @@ public interface IArchiveService
         /// <returns></returns>
         string GetPackageArchivePath(string packageId);
 
+        /// <summary>
+        /// Returns a memcache key at which archive progress object is stored at.
+        /// </summary>
+        /// <param name="packageId"></param>
+        /// <returns></returns>
         string GetArchiveProgressKey(string packageId);
 
+        /// <summary>
+        /// Returns the absolute path an archive queue file is stored at.
+        /// </summary>
+        /// <param name="packageId"></param>
+        /// <returns></returns>
         string GetPackageArchiveQueuePath(string packageId);
     }
 }

src/Tetrifact.Core/PackageArchiveCreationStates.cs

@@ -1,12 +1,12 @@
 namespace Tetrifact.Core
 {
-    public enum PackageArchiveCreationStates
+    public enum PackageArchiveCreationStates 
     {
         Queued,
         ArchiveGenerating,
         Processed_PackageNotFound,
         Processed_ArchiveAvailable,
-        Processed_ArchiveNotAvailableNotGenerated,
+        Processed_ArchiveNotGenerated,
         Processed_CleanupRequired
     }
 }

src/Tetrifact.Tests/Core/ArchiveService/GetPackageArchiveStatus.cs

@@ -43,7 +43,7 @@ public void GetArchiveStarted()
                 .Returns(false);
 
             IArchiveService archiveService = MoqHelper.CreateInstanceWithDependencies<Core.ArchiveService>(new object[] { indexReader, filesystem });
-            Assert.Equal(PackageArchiveCreationStates.Processed_ArchiveNotAvailableNotGenerated, archiveService.GetPackageArchiveStatus("any-package-id").State);
+            Assert.Equal(PackageArchiveCreationStates.Processed_ArchiveNotGenerated, archiveService.GetPackageArchiveStatus("any-package-id").State);
         }
 
         /// <summary>

src/Tetrifact.Web/Views/Shared/ArchiveProgress.cshtml

@@ -8,7 +8,7 @@
     @{ 
         // TODO :simply this if statement
     }
-    @if (Model == null || Model.State == PackageArchiveCreationStates.Processed_ArchiveNotAvailableNotGenerated || Model.State == PackageArchiveCreationStates.Processed_ArchiveAvailable || Model.State == PackageArchiveCreationStates.Processed_CleanupRequired)
+    @if (Model == null || Model.State == PackageArchiveCreationStates.Processed_ArchiveNotGenerated || Model.State == PackageArchiveCreationStates.Processed_ArchiveAvailable || Model.State == PackageArchiveCreationStates.Processed_CleanupRequired)
     { 
         <a class="button button-header" href="/v1/archives/@packageId">&#10515; Download</a>
     }