Non-recipe quality selection #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleStan
force-pushed
the
quality
branch
2 times, most recently
from
3f5d2c0
to
e93eaf5
Compare
veger
reviewed
Nov 5, 2024
veger
approved these changes
Nov 5, 2024
Co-authored-by: Maarten Bezemer <maarten.bezemer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows quality selection for everything except recipes, and should reflect the quality-related values everywhere they are relevant.
This corresponds to tasks "Select quality of crafting entity with new GUI" through "Use quality-dependent stats for modules/beacons" and "UnlockQualityModifier in TechnologyPrototype::effects for milestone analysis" in #311.