Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-email,app-preview): --base-path flag, deploy preview to sub path #247

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

shellscape
Copy link
Owner

Component / Package Name: jsx-email, app-preview

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #245

Description

Adds a new --base-path flag to the email preview command which allows deploying the app to a server sub-path instead of the server root.

@shellscape shellscape merged commit 3ebeca4 into main Nov 24, 2024
5 checks passed
@shellscape shellscape deleted the fix/jsx-email/preview-deploy-sub branch November 24, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The preview build does not work when deployed on subpath
1 participant