Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-email): restore local static assets for preview #212

Merged
merged 8 commits into from
Oct 5, 2024

Conversation

shellscape
Copy link
Owner

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR restores the ability to use local, static assets in email templates in the preview tool. This ability was initially lost due to the change to precompile templates before loading them into the vite app. The preview docs have been updated with information on how to leverage local assets in templates, and the airbnb template in /apps/demo/emails has a working example.

@shellscape shellscape merged commit b7daa41 into main Oct 5, 2024
3 checks passed
@shellscape shellscape deleted the feat/jsx-email/static-preview-back branch October 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant