Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added numbat-wasm back to workspace #600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rben01
Copy link
Contributor

@rben01 rben01 commented Oct 5, 2024

Fixed resulting clippy errors

rben01 and others added 2 commits October 5, 2024 11:58
@sharkdp
Copy link
Owner

sharkdp commented Oct 8, 2024

Thank you. We now get this cargo warning when running cargo build / cargo run:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/shark/numbat/numbat-wasm/Cargo.toml
workspace: /home/shark/numbat/Cargo.toml

It's probably caused by this profile in numbat-wasm/Cargo.toml:

[profile.release]
# Tell `rustc` to optimize for small code size.
opt-level = "s"
lto = true

but I'm not sure if moving that to the workspace root is really the best idea? Maybe we would have to rename (release-wasm) and then refer to that explicitly in our build scripts?

@rben01
Copy link
Contributor Author

rben01 commented Oct 8, 2024

Hmm, not sure how to fix this. rust-lang/cargo#8264

Mucking with the package layout just to fix this one warning doesn't seem worth it... I wonder if there's a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants