Visual and Data Pivot - read/write API #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into visual-edit-api
|
@shapiromatron passing the buck! |
# Conflicts: # hawc/apps/summary/serializers.py
shapiromatron
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
This looks great! However, I made some changes upstream in #901 with how we save the Visual settings to save it as a JSON field instead of a string field. Please review that PR first and merge it in if you're ok with it. Assuming it looks good and you're ok with the changes I made here, we can merge this one too.
|
Ok, changes LGTM @shapiromatron |
shapiromatron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, API for Visual and DataPivotQuery were read-only. Now, you can create, update, and delete as well. Validation is not performed on the settings or prefilters, so it is possible to submit visuals that may not work.